You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was raised by @BaptisteVandecrux in his latest PR #207 where the unit test was not working due to the pkg_resources package not being recognised.
I discovered the problem was with the Github Action itself - we are using an old version of the checkout and setup-python Actions, which have just been deprecated. So I have updated these in this PR.
In addition, to make sure we don't have problems from this again, I have hard coded for the setuptools package to be upgraded during the Python setup step in each Action. This should mean that the pkg_resources package will be found for running the unit test and process test.
After this PR is merged with the main branch, then you should be able to run the Actions on your PR @BaptisteVandecrux. Then you should be able to continue with merging.
My only comment is that you use checkout@v3 when they have released a checkout@v4: https://github.com/actions/checkout
I guess it doesn't matter right now but it is annoying that they deprecate things that fast.
checkout@v2's last release was May 30 this year!
My only comment is that you use checkout@v3 when they have released a checkout@v4: https://github.com/actions/checkout I guess it doesn't matter right now but it is annoying that they deprecate things that fast. checkout@v2's last release was May 30 this year!
I thought about this, but chose checkout@v3 because all examples use the specific combination of checkout@v3 and setup-python@v4. I think we can update it in the future when they begin pushing for v4 in their examples though.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was raised by @BaptisteVandecrux in his latest PR #207 where the unit test was not working due to the
pkg_resourcespackage not being recognised.I discovered the problem was with the Github Action itself - we are using an old version of the
checkoutandsetup-pythonActions, which have just been deprecated. So I have updated these in this PR.In addition, to make sure we don't have problems from this again, I have hard coded for the
setuptoolspackage to be upgraded during the Python setup step in each Action. This should mean that thepkg_resourcespackage will be found for running the unit test and process test.After this PR is merged with the main branch, then you should be able to run the Actions on your PR @BaptisteVandecrux. Then you should be able to continue with merging.